Title: Debugging an issue between Snuffleupagus and Composer
Date: 2021-02-04 13:30

The 17<sup>th</sup> of November 2020, [someone](https://github.com/wedi)
reported that [composer](https://getcomposer.org/) didn't work with
Snuffleupagus, even with an empty configuration file:

```php
$ composer
Fatal error: Uncaught TypeError: ini_set() expects parameter 2 to be string, int given in phar:///usr/local/bin/composer/bin/composer:26
Stack trace:
#0 phar:///usr/local/bin/composer/bin/composer(26): ini_set('display_errors', 1)
#1 /usr/local/bin/composer(24): require('phar:///usr/loc...')
#2 {main}
  thrown in phar:///usr/local/bin/composer/bin/composer on line 26
```

This looked like a `strict_mode` issue. PHP's
documentation about
[`ini_set`](https://www.php.net/manual/en/function.ini-set.php) shows that
there is indeed a type-related disparity: `ini_set(string, string) : string`,
called like `ini_set(string, int)` by *composer*.

So is must likely be something going on with the strict mode. Fortunately,
this feature is pretty contained:

```
$ git grep -i strict_ -- '*.c'
src/snuffleupagus.c:28:    op->fn_flags |= ZEND_ACC_STRICT_TYPES;
$
```

```C
static inline void sp_op_array_handler(zend_op_array *op) {
  if (NULL == op->filename) {
    return;
  } else {
    op->fn_flags |= ZEND_ACC_STRICT_TYPES;
  }
}
```

With `sp_op_array_handler` being set as `op_array_handler_func_t` in the
[`zend_extension_entry`](http://www.phpinternalsbook.com/php7/extensions_design/zend_extensions.html).
It looks like the strict type flag is set no matter what the administrator
wrote in their configuration.

The fix is simple: just add a check for the corresponding configuration option:

```C
static inline void sp_op_array_handler(zend_op_array *op) {
	// We need a filename, and strict mode not already enabled on this op
	if (NULL == op->filename || op->fn_flags & ZEND_ACC_STRICT_TYPES) {
		return;
	} else {
		if (true == SNUFFLEUPAGUS_G(config).config_global_strict->enable) {
			op->fn_flags |= ZEND_ACC_STRICT_TYPES;
		}
	}
}
```

Which is exactly [what was done](https://github.com/jvoisin/snuffleupagus/commit/e134c87a9a7850d1db30cfe10eb0f521b27953a5),
along with [tests]( https://github.com/jvoisin/snuffleupagus/commit/1cb80ae6a095d360bc2988a82468f3d38a876218)
and an [upstream fix]( https://github.com/composer/composer/pull/9498 ).